Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude "tests" package from dist #13

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

mbargull
Copy link
Contributor

@mbargull mbargull commented Apr 25, 2021

This removes the included "tests" package from the built distribution.
Including it will cause file collisions (/overwrites) for site-packages/tests/__init__.py on installation.
Excluding it, however, means that the sdist also does not carry this file anymore, i.e., the setup_requires=["pytest-runner"] will not pick it up anymore -- which isn't much of a regression since the tests/*.sh files aren't included in the sdist anyway. (I.e., setup_requires=["pytest-runner"] is a quasi no-op apart from when run from the repo itself (or archive of it), so, I'd suggest to remove it from setup.py and invoke pytest directly.)

@johanneskoester
Copy link
Contributor

Sounds reasonable, good catch. May I ask you to create a corresponding PR for removing the dependency (or just do it here).

@johanneskoester johanneskoester merged commit 1cbf110 into snakemake:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants