Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo update on the runtime lockfiles and the SDK lockfile #3856

Merged
merged 3 commits into from
Oct 4, 2024

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    ec23e50 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Add allowlist for audit errors to sdk-lockfiles (#3857)

    ## Motivation and Context
    Unblocks smithy-rs#3856
    
    ## Description
    See
    [README](https://github.com/smithy-lang/smithy-rs/blob/d09d1213971f698cffa11caec0ccd3c1911bc12c/tools/ci-build/sdk-lockfiles/README.md#false-positives)
    
    For those who may wonder why `sdk-lockfiles audit` returns `SUCCESS`
    with the lockfiles in the current main branch. That's because
    `pin-project` [is listed in the SDK
    lockfile](https://github.com/smithy-lang/smithy-rs/blob/3871e9aed7ed6fbecdc45a76c7a5b75f17a941b5/aws/sdk/Cargo.lock#L3256-L3263)
    due to the dependency chain: `hyper-util` -> `tower` -> `pin-project`.
    However, since the last `cargo update` in PR3856, a more recent version
    of `hyper-util` no longer depends on `pin-project`, so `pin-project`
    does not appear in the SDK lockfile.
    
    ## Testing
    - Added unit tests for the tool
    - Confirmed that this PR unblocks the target PR
    
    ----
    
    _By submitting this pull request, I confirm that you can use, modify,
    copy, and redistribute this contribution, under the terms of your
    choice._
    ysaito1001 authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ce3cbd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b764031 View commit details
    Browse the repository at this point in the history