Run cargo update on the runtime lockfiles and the SDK lockfile
#3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
## Motivation and Context Unblocks smithy-rs#3856 ## Description See [README](https://github.com/smithy-lang/smithy-rs/blob/d09d1213971f698cffa11caec0ccd3c1911bc12c/tools/ci-build/sdk-lockfiles/README.md#false-positives) For those who may wonder why `sdk-lockfiles audit` returns `SUCCESS` with the lockfiles in the current main branch. That's because `pin-project` [is listed in the SDK lockfile](https://github.com/smithy-lang/smithy-rs/blob/3871e9aed7ed6fbecdc45a76c7a5b75f17a941b5/aws/sdk/Cargo.lock#L3256-L3263) due to the dependency chain: `hyper-util` -> `tower` -> `pin-project`. However, since the last `cargo update` in PR3856, a more recent version of `hyper-util` no longer depends on `pin-project`, so `pin-project` does not appear in the SDK lockfile. ## Testing - Added unit tests for the tool - Confirmed that this PR unblocks the target PR ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CI fails, commit the necessary fixes to this PR until all checks pass. If required, update entries in crateNameToLastKnownWorkingVersions.