Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a function to return operation shapes that need a ValidationException #3720

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

drganjoo
Copy link
Contributor

@drganjoo drganjoo commented Jun 26, 2024

Refactor and define a separate function that returns a set of operation shapes that must have a supported validation exception shape in their associated errors list.

This helps identify which type of ValidationException has been added to the operation shape's errors list.

Closes: 3722

@drganjoo drganjoo requested review from a team as code owners June 26, 2024 14:46
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

drganjoo and others added 2 commits June 27, 2024 11:13
Co-authored-by: david-perez <d@vidp.dev>
…egen/server/smithy/ValidateUnsupportedConstraints.kt

Co-authored-by: david-perez <d@vidp.dev>
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@drganjoo drganjoo added the server Rust server SDK label Jun 27, 2024
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@drganjoo drganjoo added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 5498a18 Jun 28, 2024
44 checks passed
@drganjoo drganjoo deleted the fahadzub/op-ve branch June 28, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Rust server SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor validation logic to separate the function for finding operations that need a ValidationException.
2 participants