Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validation logic to separate the function for finding operations that need a ValidationException. #3722

Closed
drganjoo opened this issue Jun 27, 2024 · 0 comments · Fixed by #3720

Comments

@drganjoo
Copy link
Contributor

The function validateOperationsWithConstrainedInputHaveValidationExceptionAttached uses a Walker to find all operation shapes that should have a ValidationException in the errors list, then filters out the ones that don't have it to raise an error.

The logic to find all such operations that need a ValidationException should be defined as a separate function. This will be helpful in other parts of the codebase that might need to determine which kind of ValidationException has been added to operations.

github-merge-queue bot pushed a commit that referenced this issue Jun 28, 2024
…xception` (#3720)

Refactor and define a separate function that returns a set of operation
shapes that must have a supported validation exception shape in their
associated errors list.

This helps identify which type of `ValidationException` has been added
to the operation shape's errors list.

Closes: [3722](#3722)

---------

Co-authored-by: Fahad Zubair <fahadzub@amazon.com>
Co-authored-by: david-perez <d@vidp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant