Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semver hazard in S3 stalled stream protection test #3541

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Fix semver hazard in S3 stalled stream protection test #3541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions aws/sdk/integration-tests/s3/tests/stalled-stream-protection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,14 @@ async fn test_stalled_stream_protection_for_downloads_is_enabled_by_default() {
err.to_string(),
"minimum throughput was specified at 1 B/s, but throughput of 0 B/s was observed"
);
// 1s check interval + 5s grace period
assert_eq!(start.elapsed().as_secs(), 6);
// 5s grace period
// TODO(https://github.com/smithy-lang/smithy-rs/issues/3510): Currently comparing against 5 and 6 due to
// the behavior change in #3485. Once that feature/fix is released, this should be changed to only check for 5.
let elapsed_secs = start.elapsed().as_secs();
assert!(
elapsed_secs == 5 || elapsed_secs == 6,
"elapsed secs should be 5 or 6, but was {elapsed_secs}"
)
}

async fn start_faulty_download_server() -> (impl Future<Output = ()>, SocketAddr) {
Expand Down