Fix semver hazard in S3 stalled stream protection test #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging #3485 uncovered a semver hazard in the S3 stalled stream protection test due to a subtle (but intentional) change in grace period behavior for stalled streams. That semver hazard was going to cause the SDK release to fail, so #3485 was reverted, and this PR modifies the test so that it will pass with both versions of stalled stream protection as a temporary measure. Once this PR is merged and released, then the new stalled stream protection can be merged again.
I tested this by updating the runtime-versioner in #3540 so that I could patch the currently released SDK with these test changes in place, with a local copy of smithy-rs that has the new stalled stream protection implementation. I ran all the tests across all the services in this configuration to verify this was the only hazard that will be hit.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.