Add support for SSO bearer token authentication to the SDK #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR creates a trait to provide access tokens, which will be used to configure token providers in `SdkConfig`. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
jdisanti
added a commit
that referenced
this pull request
Mar 1, 2024
This PR adds the Code Catalyst service to the smoke test models, which is already done as part of #3453, but having it as a separate commit that merges before #3453 will allow us to see a codegen diff on the Code Catalyst service during review of that feature. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Mar 4, 2024
aws/sdk/integration-tests/codecatalyst/tests/sso_bearer_auth.json
Outdated
Show resolved
Hide resolved
ysaito1001
reviewed
Mar 4, 2024
Comment on lines
+84
to
+86
| /// Note: the [`Self::bearer_token`] and [`Self::bearer_token_resolver`] methods are | ||
| /// equivalent to this method, but take the [`Token`] and [`ResolveIdentity`] types | ||
| /// respectively. |
There was a problem hiding this comment.
Thanks for adding these notes!
rcoh
reviewed
Mar 5, 2024
| /// ```no_run | ||
| /// make_test!(live: test_name) | ||
| /// ``` | ||
| macro_rules! make_test { |
There was a problem hiding this comment.
should we give this macro a different name?
Comment on lines
+490
to
+497
| let err = DisplayErrorContext( | ||
| &self | ||
| .token_provider | ||
| .resolve_token(self.time_source.clone()) | ||
| .await | ||
| .expect_err("expected failure"), | ||
| ) | ||
| .to_string(); |
There was a problem hiding this comment.
we should make an extension trait that does this
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SSO bearer token authentication to the AWS SDK, specifically for Code Catalyst, which requires authentication via SSO with a Builder ID using a bearer token rather than SigV4.
This functionality was developed in a feature branch, and this PR merely merges that branch to main. The changes consist of the following previous PRs:
All these changes have been reviewed in the previous PRs, but it would be good to review this again as a whole to verify it all looks good.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.