Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRF-367 Fix use of getRoundRobinAddress in VRF listener (#8653) #8660

Merged
merged 2 commits into from
Mar 9, 2023
Merged

VRF-367 Fix use of getRoundRobinAddress in VRF listener (#8653) #8660

merged 2 commits into from
Mar 9, 2023

Conversation

jinhoonbang
Copy link
Contributor

  • VRF-367 Fix use of getRoundRobinAddress in VRF listener

related PR in develop branch: #8653

@vreff @jinhoonbang
VRF-367 Fix use of getRoundRobinAddress in VRF listener (#8653)
2713e22 
* VRF-367 Fix use of getRoundRobinAddress in VRF listener

* Move round robin call to inside SQLX callback

* Add empty slice check

* Add comments

* Revert "Move round robin call to inside SQLX callback"

This reverts commit 8a21518.

* Move fromAddress validation to validate.go

* Update job spec tests

* Revert "Move fromAddress validation to validate.go"

This reverts commit 28d0279.

* Remove specs test changes

* Fix nit

* Fix integration tst

* Revert "Revert "Move fromAddress validation to validate.go""

This reverts commit b8b2a22.

* Adjust validation

* Fix integration test model

* Fix other integration test

* Adjust integration test

* Fix lint
@jinhoonbang jinhoonbang requested a review from chainchad March 8, 2023 23:53
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jinhoonbang jinhoonbang requested review from makramkd and vreff March 8, 2023 23:53
@jinhoonbang jinhoonbang marked this pull request as ready for review March 8, 2023 23:53
@jinhoonbang jinhoonbang requested review from a team as code owners March 8, 2023 23:53
vreff
vreff previously approved these changes Mar 8, 2023
View reviewed changes
makramkd
makramkd previously approved these changes Mar 9, 2023
View reviewed changes
@makramkd
Copy link
Contributor

makramkd commented Mar 9, 2023

Looks like integration test build failed, re-running.

@makramkd makramkd mentioned this pull request Mar 9, 2023
Merged
@makramkd makramkd dismissed stale reviews from vreff and themself via db00218 March 9, 2023 10:55
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition B Maintainability Rating on New Code (is worse than A)
Failed condition 76.5% 76.5% Coverage on New Code (is less than 90%)
Failed condition 5.9% 5.88% Duplicated Lines (%) on New Code (is greater than 3%)
Failed condition 5.46% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

chainchad
chainchad approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@chainchad chainchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed no diff from the commit (2713e22) in develop

@chainchad chainchad merged commit e75ebc5 into release/1.13.0 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad approved these changes

@vreff vreff vreff left review comments

@makramkd makramkd makramkd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinhoonbang @makramkd @chainchad @vreff