VRF-367 Fix use of getRoundRobinAddress in VRF listener

[vreff]

Moves the call to GetRoundRobinAddress from outside the pipeline simulation to right before the SqlxTransaction callback function, as to make round robin more accurate in-practice.
Open questions:

• Do we ever plan to specify different key-specific gas limits for VRFv2? Currently all "fromAddresses" get the same gas price limits.
• Do we want to move the GetRoundRobinAddress call to be inside the SqlxTransaction call? Or is it acceptable being right before it?

[github-actions]

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

[makramkd]

Do we ever plan to specify different key-specific gas limits for VRFv2? Currently all "fromAddresses" get the same gas price limits.

All key-specific max gas price configurations MUST be the same and the gasLanePrice job spec parameter can be used to enforce that (see

chainlink/core/services/vrf/delegate.go

Line 192 in 9c3f5d5

func CheckFromAddressMaxGasPrices(jb job.Job, cfg Config) (err error) {

)

Do we want to move the GetRoundRobinAddress call to be inside the SqlxTransaction call? Or is it acceptable being right before it?

I think moving the GetRoundRobinAddress call to be right before the CreateEthTransaction call should be fine, even if it's inside the Transaction call for sqlx.

[cl-sonarqube-production]

SonarQube Quality Gate

Maintainability Rating on New Code (is worse than A)
76.5% Coverage on New Code (is less than 90%)
5.88% Duplicated Lines (%) on New Code (is greater than 3%)
5.46% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint in your IDE.