Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted txm + fees from core #475

Merged
merged 17 commits into from
Mar 13, 2023
Merged

Extracted txm + fees from core #475

merged 17 commits into from
Mar 13, 2023

Conversation

sdrug
Copy link
Contributor

@sdrug sdrug commented Mar 3, 2023 •
edited
Loading

Ticket
Summary of transition:

  • Fixed tests
  • Got rid of some core dependencies (e.g. testutils)
  • Switched to local package analogues (e.g. core logger -> relay logger)
  • No changes to the txm logic
  • Keystore dependency preserved for now

@sdrug sdrug temporarily deployed to integration March 3, 2023 23:34 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 3, 2023 23:37 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 3, 2023 23:37 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 3, 2023 23:38 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 5, 2023 19:12 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 5, 2023 19:12 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 5, 2023 19:12 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 5, 2023 19:33 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 5, 2023 19:33 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 5, 2023 19:33 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 5, 2023 19:39 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 5, 2023 19:45 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 6, 2023 00:05 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 6, 2023 00:05 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 6, 2023 00:06 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 6, 2023 00:12 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 6, 2023 00:18 — with GitHub Actions Inactive
@sdrug sdrug mentioned this pull request Mar 6, 2023
Merged
@sdrug sdrug requested a review from jmank88 March 6, 2023 12:41
@sdrug sdrug temporarily deployed to integration March 8, 2023 14:58 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 8, 2023 15:05 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 8, 2023 15:11 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 8, 2023 16:15 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 8, 2023 16:17 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 8, 2023 16:17 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 8, 2023 16:17 — with GitHub Actions Inactive
@sdrug sdrug temporarily deployed to integration March 8, 2023 16:23 — with GitHub Actions Inactive
@sdrug
Copy link
Contributor Author

sdrug commented Mar 8, 2023

@aalu1418 @jmank88
Please give it another try. Related PRs:

@sdrug sdrug temporarily deployed to integration March 8, 2023 16:30 — with GitHub Actions Inactive
aalu1418
aalu1418 reviewed Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! I will wait until the PR in chainlink-relay gets merged and the reference gets bumped for final approval

jmank88
jmank88 reviewed Mar 9, 2023
View reviewed changes
pkg/solana/keys/key.go Outdated Show resolved Hide resolved
@aalu1418
solana txm to use simple keystore interface (#480)
77ac97d 
* convert txm to use simple Sign interface

* bump chainlink-relay
@aalu1418 aalu1418 temporarily deployed to integration March 9, 2023 18:12 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration March 9, 2023 18:12 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration March 9, 2023 18:12 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration March 9, 2023 18:19 — with GitHub Actions Inactive
@aalu1418 aalu1418 temporarily deployed to integration March 9, 2023 18:26 — with GitHub Actions Inactive
@aalu1418
Copy link
Collaborator

aalu1418 commented Mar 9, 2023

corresponding core PR with keystore changes: smartcontractkit/chainlink#8627

@aalu1418 aalu1418 requested review from jmank88 and aalu1418 March 9, 2023 18:39
@aalu1418 aalu1418 merged commit 6270bc7 into develop Mar 13, 2023
@aalu1418 aalu1418 deleted the txm-from-core branch March 13, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdrug @augustbleeds @aalu1418 @jmank88