Modules from core #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalu1418
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Can you copy over the test files for the utils that you copied over too?
Also to fix the failing solana CI check I think you can remove this line: https://github.com/smartcontractkit/chainlink-relay/blob/0298f0e913fe98bcbf2d5a4c95f33b08a968dd59/.github/workflows/build_external.yml#L62
jmank88
reviewed
Mar 8, 2023
| @@ -31,3 +31,12 @@ type ErrEmpty struct { | |||
| func (e ErrEmpty) Error() string { | |||
| return fmt.Sprintf("%s: empty: %s", e.Name, e.Msg) | |||
| } | |||
|
|
|||
| type KeyNotFoundError struct { | |||
There was a problem hiding this comment.
It's being used in the txm tests, for example here.
There was a problem hiding this comment.
Hmmm OK - we might have to revisit this with plugins, since error types are not preserved over the wire. Fortunately it seems like we could just return nil instead of a custom error for this particular case.
aalu1418
approved these changes
Mar 9, 2023
|
Merging this part of work for now. The further improvements will follow in Aaron's PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.