Implement WebView component for external services #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO |
marcometz
approved these changes
Jun 3, 2019
SoleCincis
approved these changes
Jun 3, 2019
donni106
force-pushed
the
feature/share-contents
branch
from
09fe0f6 to
83e8145
Compare
donni106
force-pushed
the
feature/external-services-per-webview
branch
from
c0125e8 to
e62619f
Compare
Kann noch nicht verwendet werden mit Expo, ist noch in progress: https://expo.canny.io/feature-requests/p/react-native-webview-support |
- created new route `Web` for navigating to a `WebView` - created a `WebScreen` for rendering a `WebView` with loading indicator - updated the `HtmlScreen` with adding a `Button` if a `webUrl` is given in navigation params - created a `Button` component based on React Native Elements Button: https://react-native-training.github.io/react-native-elements/docs/button.html resolves #2
donni106
force-pushed
the
feature/external-services-per-webview
branch
from
e62619f to
f1c31ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webfor navigating to aWebViewWebScreenfor rendering aWebViewwith loading indicatorHtmlScreenwith adding aButtonif awebUrlis given in navigation paramsButtoncomponent based on React Native ElementsButton: https://react-native-training.github.io/react-native-elements/docs/button.html
resolves #2
ℹ️merge #13 first and change the base of this PR to master