Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simple share function of detail screens #13

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

donni106
Copy link
Member


share dialog iOS
IMG_349D258B930F-1

share content example

[Bad Belzig App] 28.05.2019 | RSS: Dörferberatung – Ein Fazit

@donni106 donni106 added the enhancement New feature or request label May 31, 2019
@donni106 donni106 added this to the 0.6.8 milestone May 31, 2019
@donni106 donni106 self-assigned this May 31, 2019
src/screens/HomeScreen.js Outdated Show resolved Hide resolved
src/screens/DetailScreen.js Show resolved Hide resolved
- https://docs.expo.io/versions/v32.0.0/react-native/share
- created share helper function
- added params for shareContent to navigation params, that will
  be used for share dialog opened from DetailScreen
- created `shareMessage()` helper to build the message to share
- refactored `getQuery` to `/queries/index.js` to use everywhere from one place
- added missing line trimming of HtmlView in DetailScreen
@donni106 donni106 force-pushed the feature/share-contents branch from 09fe0f6 to 83e8145 Compare June 3, 2019 15:20
@smart-village-solutions smart-village-solutions deleted a comment from codeclimate bot Jun 3, 2019
@donni106 donni106 merged commit 06c527a into master Jun 3, 2019
@donni106 donni106 deleted the feature/share-contents branch June 3, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants