Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for membership #428

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Request for membership #428

merged 2 commits into from
Jul 27, 2022

Conversation

naveensrinivasan
Copy link
Collaborator

@naveensrinivasan
Request for membership
f5f6a4e 
- I would like request for membership.

My contributions https://github.com/slsa-framework/slsa-github-generator/pulls?q=is%3Apr+author%3Anaveensrinivasan

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan mentioned this pull request Jul 12, 2022
Open
@naveensrinivasan
Copy link
Collaborator Author

@laurentsimon I don't know much of TS to contribute to actions. What other feature can I contribute?

@laurentsimon
Copy link
Collaborator

Any other existing issues maybe?

@naveensrinivasan
Copy link
Collaborator Author

Any other existing issues maybe?

Took up the feature as it was discussed and implemented it #546

@ianlewis
Copy link
Member

ianlewis commented Jul 26, 2022 •
edited
Loading

Trying to summarize what we want to set as requirements and what roles we are going to grant based on previous discussion.
slsa-framework/slsa#403

I think we want to start by giving Naveen a "contributor" role that is similar to a "reviewer" role in Kubernetes. We can adjust
or migrate once we have a more solid contributor ladder.

Requirements

Responsibilities and privileges

  • "read and triage" access to the slsa-github-generator repository.
  • Added to CODEOWNERS file
  • Expected to help review PRs and address bugs related to area of expertise

@laurentsimon Does this look good? If so please approve the PR (I think we should have both our approvals on this one).

laurentsimon
laurentsimon approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianlewis ianlewis enabled auto-merge (squash) July 27, 2022 02:58
@ianlewis
Copy link
Member

Hmm, the CODEOWNERS file complains that Naveen doesn't have write access to the repository, but the docs say you only need read access as a user.

@ianlewis ianlewis merged commit 9875820 into slsa-framework:main Jul 27, 2022
@ianlewis
Copy link
Member

Hmm, the CODEOWNERS file complains that Naveen doesn't have write access to the repository, but the docs say you only need read access as a user.

It seems ok, it just doesn't add Naveen to new PRs as a reviewer. Maybe it only starts working once Naveen accepts the invitation?

@ianlewis ianlewis mentioned this pull request Nov 24, 2022
Merged
10 tasks
@ianlewis ianlewis mentioned this pull request Dec 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianlewis ianlewis ianlewis approved these changes

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naveensrinivasan @laurentsimon @ianlewis