Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test : Included tests for build.go #351

Merged

Conversation

naveensrinivasan
Copy link
Collaborator

  • Included tests for build.go

Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com

@naveensrinivasan
Copy link
Collaborator Author

@laurentsimon 👀

Copy link
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

internal/builders/go/pkg/build_test.go Outdated Show resolved Hide resolved
internal/builders/go/pkg/build_test.go Show resolved Hide resolved
internal/builders/go/pkg/build_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Wondering as well (non-blocking), for dry=false, can we look for the output binary to make sure we build something?

@naveensrinivasan
Copy link
Collaborator Author

Thanks! LGTM

Wondering as well (non-blocking), for dry=false, can we look for the output binary to make sure we build something?

As I mentioned in the previous comment I will do that in the follow up PR.

internal/builders/go/pkg/build_test.go Outdated Show resolved Hide resolved
internal/builders/go/pkg/build_test.go Outdated Show resolved Hide resolved
- Included tests for build.go

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@ianlewis ianlewis merged commit 46d87be into slsa-framework:main Jun 22, 2022
@ianlewis ianlewis mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants