Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make build dirs of java builders unique #2665

Merged
merged 3 commits into from
Aug 21, 2023
Merged

chore: make build dirs of java builders unique #2665

merged 3 commits into from
Aug 21, 2023

Conversation

AdamKorcz
Copy link
Collaborator

Fixes the following from #2662:

  • The internal Action. It must add randomization and return a new output
  • The publish / download Actions. They need an additional input for the randomized name.

@AdamKorcz
chore: make build dirs of java builders unique
35aac5e 
Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz AdamKorcz force-pushed the java-builders-add-rng branch from e03669d to 35aac5e Compare August 21, 2023 11:31
This was referenced Aug 21, 2023
Closed
Merged
laurentsimon
laurentsimon reviewed Aug 21, 2023
View reviewed changes
internal/builders/gradle/action.yml Outdated Show resolved Hide resolved
internal/builders/maven/action.yml Outdated Show resolved Hide resolved
.github/workflows/builder_gradle_slsa3.yml Outdated Show resolved Hide resolved
@AdamKorcz
update names to be 'build' for gradle and 'target' for maven
3a887f1 
Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz
Copy link
Collaborator Author

@laurentsimon PTAL

@AdamKorcz
Copy link
Collaborator Author

@laurentsimon PTAL again.

@laurentsimon laurentsimon enabled auto-merge (squash) August 21, 2023 16:50
@laurentsimon
Copy link
Collaborator

Thanks for the fast turn around @AdamKorcz !
Let's merge and see if it works in the e2e tests.

@AdamKorcz
Copy link
Collaborator Author

AdamKorcz commented Aug 21, 2023 •
edited
Loading

@laurentsimon thanks, I will propagate the updates on the e2e-tests side.

@laurentsimon
Copy link
Collaborator

some GitHub problems 503 in pre-submits, etc. Re-running

@laurentsimon
Copy link
Collaborator

Can you force push to trigger the pre-submit again?

@AdamKorcz
remove unnecessary renaming of output dir
165b708 
Signed-off-by: AdamKorcz <adam@adalogics.com>
auto-merge was automatically disabled August 21, 2023 17:50

Head branch was pushed to by a user without write access

@AdamKorcz AdamKorcz force-pushed the java-builders-add-rng branch from d9e99b7 to 165b708 Compare August 21, 2023 17:50
@AdamKorcz
Copy link
Collaborator Author

@laurentsimon All green!

@laurentsimon laurentsimon merged commit b6d7cbf into slsa-framework:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@ianlewis ianlewis Awaiting requested review from ianlewis

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

@kpk47 kpk47 Awaiting requested review from kpk47 kpk47 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamKorcz @laurentsimon