Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make artifact name in java builders unique #281

Merged
merged 2 commits into from
Aug 21, 2023
Merged

make artifact name in java builders unique #281

merged 2 commits into from
Aug 21, 2023

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz commented Aug 21, 2023 •
edited
Loading

@AdamKorcz
make artifact name in java builders unique
1d931fe 
Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz AdamKorcz mentioned this pull request Aug 21, 2023
Closed
@AdamKorcz
Update build directory name
07e34e4 
Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz
Copy link
Contributor Author

@laurentsimon PTAL

laurentsimon
laurentsimon approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
I'll wait for the gen PR to merge and then merge this one.

@laurentsimon laurentsimon merged commit 06cfe1f into slsa-framework:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@ianlewis ianlewis Awaiting requested review from ianlewis

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamKorcz @laurentsimon