Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to cpp and rust docs #7263

Merged
merged 2 commits into from
Jan 3, 2025
+2 −2
Merged

Fix broken links to cpp and rust docs #7263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77783be
Fix broken links to cpp and rust docs
NigelBreslaw Jan 3, 2025
a79e27c
Make url consistent with other uses in docs
NigelBreslaw Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/astro/src/content/docs/guide/language/coding/file.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,9 @@ The path to each library, as file or directory, must be defined separately at co
Use one of the following methods to help the Slint compiler resolve libraries to the correct
path on disk:

* When using Rust and `build.rs`, call [`with_library_paths`](slint-build-rust:struct.CompilerConfiguration#method.with_library_paths)
* When using Rust and `build.rs`, call [`with_library_paths`](https://docs.slint.dev/latest/docs/rust/slint_build/struct.CompilerConfiguration#method.with_library_paths)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, when we link from the Rust API docs to the Slint docs, we use a versioned link, so releases.slint.dev/1.9.1/docs/rust/index.html does link to https://releases.slint.dev/1.9.0/docs/slint/ . Shouldn't the links back also be versioned then?

(This is not a blocker for this PR, as the previous link was broken altogether, more a general comment/thought :-)

to provide a mapping from library name to path.
* When using C++, use `LIBRARY_PATHS` with [`slint_target_sources`](slint-cpp:cmake_reference#slint-target-sources).
* When using C++, use `LIBRARY_PATHS` with [`slint_target_sources`](https://docs.slint.dev/latest/docs/cpp/cmake_reference#slint-target-sources).
* When invoking the `slint-viewer` from the command line, pass `-Lmylibrary=/path/to/my/library` for each component
library.
* When using the VS Code extension, configure the Slint extension's library path
Expand Down
Loading