Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to cpp and rust docs #7263

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

NigelBreslaw
Copy link
Member

Fixes #7222

@ogoffart
Copy link
Member

ogoffart commented Jan 3, 2025

Not a fan of having hardcoded link to latest in there.
It should at least be consistant and we've used links to slint.dev/docs before.
eg: https://github.com/slint-ui/slint/blob/master/docs/astro/src/content/docs/guide/development/translations.mdx?plain=1#L210

Can't astro generate the correct link like the previous docs did, using some javascript magic?

@@ -338,9 +338,9 @@ The path to each library, as file or directory, must be defined separately at co
Use one of the following methods to help the Slint compiler resolve libraries to the correct
path on disk:

* When using Rust and `build.rs`, call [`with_library_paths`](slint-build-rust:struct.CompilerConfiguration#method.with_library_paths)
* When using Rust and `build.rs`, call [`with_library_paths`](https://docs.slint.dev/latest/docs/rust/slint_build/struct.CompilerConfiguration#method.with_library_paths)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, when we link from the Rust API docs to the Slint docs, we use a versioned link, so releases.slint.dev/1.9.1/docs/rust/index.html does link to https://releases.slint.dev/1.9.0/docs/slint/ . Shouldn't the links back also be versioned then?

(This is not a blocker for this PR, as the previous link was broken altogether, more a general comment/thought :-)

@NigelBreslaw NigelBreslaw merged commit 1ed40e6 into master Jan 3, 2025
37 checks passed
@NigelBreslaw NigelBreslaw deleted the nigel/docs-lang-fix branch January 3, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: broken links to backend api
3 participants