Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[builtin_handlers]: ServerErrorRetryHandler, renaming _can_retry_async -> _can_retry #1372

Merged
merged 1 commit into from
May 23, 2023

Conversation

maximkir-fl
Copy link
Contributor

@maximkir-fl maximkir-fl commented May 23, 2023

Summary

Bugfix for #1367

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @maximkir-fl to sign the Salesforce Inc. Contributor License Agreement.

maximkir-fl referenced this pull request May 23, 2023
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels May 23, 2023
@seratch seratch modified the milestones: 3.21.4, 3.22.0 May 23, 2023
@seratch seratch self-assigned this May 23, 2023
@seratch seratch merged commit 3afc31a into slackapi:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants