-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built in server error retry handlers #1367
Add built in server error retry handlers #1367
Conversation
Thanks for the contribution! Before we can merge this, we need @digitalnomd to sign the Salesforce Inc. Contributor License Agreement. |
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
We already have a few unit tests for the built-in retry handlers. If you could add some for the new handler, it'd be greatly appreciated. Otherwise, I can add some tests when merging your changes. |
Codecov Report
@@ Coverage Diff @@
## main #1367 +/- ##
==========================================
- Coverage 85.58% 85.55% -0.04%
==========================================
Files 111 111
Lines 11559 11569 +10
==========================================
+ Hits 9893 9898 +5
- Misses 1666 1671 +5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for taking your time to make this PR! After merging the changes, I will add a few unit tests for them |
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Summary
This pull request resolves #1364
Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.