Fix Leaf deleteText with embed tag nodes #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,6 +84,19 @@ describe('Leaf', -> | |||
| ) | |||
| ) | |||
|
|
|||
| describe('deleteText() with embed tags', -> | |||
| beforeEach( -> | |||
There was a problem hiding this comment.
Since there's only one test can you move these two lines into the anonymous function passed into it()?
|
Thanks for the PR! I made a couple of comments so with those updated this should be good to go |
leoasis
force-pushed
the
fix_leaf_delete_text_embed_tag
branch
from
63f8af3
to
268390e
Compare
|
Check it out now! |
jhchen
added a commit
that referenced
this pull request
Sep 19, 2014
Fix Leaf deleteText with embed tag nodes
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.