Merge pull request #215 from leoasis/fix_leaf_delete_text_embed_tag

Fix Leaf deleteText with embed tag nodes
slab · Sep 19, 2014 · 102a59f · 102a59f
2 parents e58238a + 268390e
commit 102a59f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/core/leaf.coffee b/src/core/leaf.coffee
@@ -22,7 +22,7 @@ class Leaf extends LinkedList.Node
     @length = @text.length
     if dom.EMBED_TAGS[@node.tagName]?
       textNode = @node.ownerDocument.createTextNode(@text)
-      @node = dom(@node).replace(@textNode)
+      @node = dom(@node).replace(textNode)
     else
       dom(@node).text(@text)
 

diff --git a/test/unit/core/leaf.coffee b/test/unit/core/leaf.coffee
@@ -84,6 +84,18 @@ describe('Leaf', ->
     )
   )
 
+  describe('deleteText() with embed tags', ->
+    it('removes the embed tag and replaces it with an empty text node', ->
+      @container.innerHTML = '<img>'
+      leaf = new Quill.Leaf(@container.firstChild, {})
+
+      leaf.deleteText(0, 1)
+
+      expect(leaf.text).toEqualHTML('')
+      expect(dom(leaf.node).text()).toEqualHTML('')
+    )
+  )
+
   describe('insertText()', ->
     tests =
       'element with text node':