Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clone dependency to >=2.1.1 <2.2 #1359

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Update clone dependency to >=2.1.1 <2.2 #1359

merged 1 commit into from
Mar 9, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Mar 9, 2017

In version 2.1.1, CloneJS improved support for Internet Explorer. See this pull request for details: pvorb/clone#77

From my limited testing so far, the fixes in CloneJS should enable QuillJS to run on a wider variety of Windows + Internet Explorer systems. For example, I've seen the dependency update fix some crashes of QuillJS on Internet Explorer 10 running on Windows Server 2012 R2.

If you're interested in merging this pull request, we should add some more Windows + Internet Explorer systems to the Saucelabs test matrix for QuillJS and see if we can increase support. Is this something that you'd be interested in doing?

In version 2.1.1, CloneJS improved support for Internet Explorer. See
this pull request for details: pvorb/clone#77

From my limited testing so far, the fixes in CloneJS should enable
QuillJS to run on a wider variety of Windows + Internet Explorer
systems. For example, I've seen the dependency update fix some crashes
of QuillJS on Internet Explorer 10 running on Windows Server 2012 R2.
@c-w
Copy link
Contributor Author

c-w commented Mar 9, 2017

The Travis build is failing due to an authentication error with Saucelabs:

  Sauce Labs Authentication Error.

You used username 'None' and access key 'None' to authenticate, which are not valid Sauce Labs credentials.

Could you please advise me how to fix this error? I've seen all tests pass locally.

@jhchen
Copy link
Member

jhchen commented Mar 9, 2017

Apologies travis was not working for Pull Requests. I can merge this request but a major blocker for IE10 is because Quill uses MutationObservers.

@jhchen jhchen merged commit 5435970 into slab:develop Mar 9, 2017
@c-w
Copy link
Contributor Author

c-w commented Mar 10, 2017

Thanks for the merge @jhchen. Would you be open to including a polyfill for MutationObserver into Quill to add support for IE9 and IE10? If so: I'd be happy to open a pull request to implement this.

@jhchen
Copy link
Member

jhchen commented Mar 10, 2017

I don't think that polyfill (or any other I'm aware of) works for contenteditable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants