Improve support for Internet Explorer #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the MSDN documentation [1], in the Javascript engine of Internet Explorer, the class passed into the instanceof method must be defined or the instanceof method may crash. This commit introduces a wrapper around instanceof that makes sure that we never call `something instanceof null` or `something instanceof undefined` thus avoiding this source of crashes. [1] https://msdn.microsoft.com/en-us/library/zh0zb36z(v=vs.94).aspx#Parameters
Internet Explorer's implementation of the Map and Set types does not provide a `myset.keys()` method which means that cloning those types fails when running on IE. This commit replaces the calls to `keys` with `forEach` which is supported in Chrome, Firefox and IE [1, 2]. [1] https://msdn.microsoft.com/en-us/library/dn280909(v=vs.94).aspx [2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/forEach
rictic
approved these changes
Mar 9, 2017
|
Yes, I also had a look and everything looks good to me. @c-w Thanks for testing this on IE and fixing the issue right away. If you'd like to be mentioned in the package.json, feel free to add yourself to the list of contributors and push again on your branch. |
|
BTW, v2.1.1 is on npm |
|
Thanks for the quick merge and version bump. I encountered these bugs while working with QuillJS so maybe we'll enable them to support older versions of IE now too. |
jhchen
pushed a commit
to slab/quill
that referenced
this pull request
Mar 9, 2017
In version 2.1.1, CloneJS improved support for Internet Explorer. See this pull request for details: pvorb/clone#77
|
That project looks promising, didn't know about it. Nice to see you can make use of this little library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two bugs with cloning Maps and Sets on IE:
instanceofto be defined.Map.keys()andSet.keys().These bugs currently cause the "clone a native Map" and "clone a native Set" tests in
test.htmlto fail on Internet Explorer:After applying the changes in this pull request, all the test-cases in
test.htmlpass on Internet Explorer, Chrome and Firefox.