Issue #800: Fix clang function declaration without a prototype errors

[jiridanek]

No description provided.

[codecov-commenter]

Codecov Report

Base: 27.48% // Head: 27.47% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4337714) compared to base (fd4d6af).
Patch coverage: 62.96% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   27.48%   27.47%   -0.02%     
==========================================
  Files         132      133       +1     
  Lines       31647    31653       +6     
  Branches     5063     5063              
==========================================
- Hits         8698     8696       -2     
- Misses      21847    21853       +6     
- Partials     1102     1104       +2     

Flag	Coverage Δ
unittests	27.47% <62.96%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
include/qpid/dispatch/delivery_state.h	0.00% <ø> (ø)
src/adaptors/adaptor_buffer.c	0.00% <0.00%> (ø)
src/adaptors/adaptor_buffer.h	0.00% <ø> (ø)
src/adaptors/http1/http1_codec.c	0.00% <0.00%> (ø)
src/adaptors/tcp/tcp_adaptor.c	2.05% <ø> (ø)
src/delivery_state.c	0.00% <0.00%> (ø)
src/log.c	65.50% <0.00%> (-0.63%)	⬇️
src/policy.c	25.89% <0.00%> (ø)
src/router_core/delivery.h	0.00% <0.00%> (ø)
tests/clogger.c	0.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jiridanek]

This now reveals the Coverity issue as compile error

../src/adaptors/http_common.c: In function ‘qd_load_http_adaptor_config’:
../src/adaptors/http_common.c:99:9: error: too many arguments to function ‘qd_error_code’
   99 |         qd_error_code(QD_ERROR_CONFIG, "Invalid value for HTTP version: %s, expected 'HTTP1' or 'HTTP2'", version_str);
      |         ^~~~~~~~~~~~~
In file included from ../src/entity.h:22,
                 from ../src/adaptors/adaptor_common.h:24,
                 from ../src/adaptors/http_common.h:22,
                 from ../src/adaptors/http_common.c:20:
../include/qpid/dispatch/error.h:88:22: note: declared here
   88 | QD_EXPORT qd_error_t qd_error_code(void);
      |                      ^~~~~~~~~~~~~