Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISPATCH-2368: chore(build): add a missing (void) into C function declarations #1705

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

jiridanek
Copy link
Contributor

@jiridanek jiridanek commented Dec 27, 2024

This is an intermediate step (in C23 this can be handled differently), but for now it's the most reasonable fix.

Previously already fixed in skupper-router

Fixes compilation failures such as this one

error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]

…eclarations

This is an intermediate step (in C23 this can be handled differently), but for now it's the most reasonable fix.

Fixes compilation failures such as this one

```
error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
```
@jiridanek jiridanek changed the title check if packit integration works DISPATCH-2368: chore(build): add a missing (void) into C function declarations Jan 13, 2025
@jiridanek
Copy link
Contributor Author

CI keeps failing the expected ways, so should be fine.

@jiridanek jiridanek merged commit fd94849 into apache:main Jan 13, 2025
18 of 25 checks passed
@jiridanek jiridanek deleted the jd_fix_build branch January 13, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant