Fix decoding of data classes in maps, and denormalizing map keys consistently #444
+88
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When nodes were being denormalized for extracting into maps or hikara data sources, it was being done recursively. Therefore, nodes further down the tree were seeing only the denormalized keys. Make the `denormalize` function non-recursive to fix this issue. Further, make denormalization more targeted -- rather than a class which denormalizes all nodes passed to a downstream denormalizer (`MapDecoder` and `HikaraDataSourceDecoder`) each of these decoders now denormalizes directly. This simplifies the code and clarifies intent.
This also fixes some existing unit tests which now have the correct expected value.
This was referenced Aug 16, 2024
|
@sksamuel Sorry, put the comment on the issue instead of the PR... would appreciate a review and merge of this asap, because current master is a bit broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #443.
This PR starts from the regression repro created by @osoykan (b256e2e), modifies it to a minimal issue reproduction (4b70665), and then fixes the two related problems (da9706c and 3922914).