Implement idiomatic environment variable handling #414
+319
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2024
rocketraman
force-pushed
the
rg/env-var-idiomatic
branch
2 times, most recently
from
fafb6a4
to
45e0f94
Compare
rocketraman
force-pushed
the
rg/env-var-idiomatic
branch
3 times, most recently
from
5448e02
to
7bcd7ab
Compare
Closed
rocketraman
force-pushed
the
rg/env-var-idiomatic
branch
4 times, most recently
from
f0f6b50
to
29ff9c4
Compare
rocketraman
force-pushed
the
rg/env-var-idiomatic
branch
from
29ff9c4
to
e5b0a86
Compare
rocketraman
force-pushed
the
rg/env-var-idiomatic
branch
from
e5b0a86
to
c942eb0
Compare
rocketraman
force-pushed
the
rg/env-var-idiomatic
branch
from
c942eb0
to
95f4988
Compare
|
@sksamuel Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the capability exposed by #413 to implement idiomatic environment variable handling.
Fixes #410.
I've tried to implement this in a backward compatible way, but if we are ok with breaking compatibility for 3.0, given the new path normalization capability, we could replace the existing logic for env vars and simplify it down to always apply env vars with the new logic, removing the
EnvironmentVariableOverridePropertySourceand simplifyingEnvironmentVariablesPropertySourceto remove all the config vals, which is what I understood from #413 (comment).This PR is stacked on top of #413 and will be rebased and moved out of draft once that PR is merged.There is a test failure in this PR which will be resolved once #444 is merged.