Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inversion of skos:hasTopConcept and skos:topConceptOf #230

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

sroertgen
Copy link
Contributor

Merged into dev for testing

@sroertgen sroertgen linked an issue Dec 16, 2022 that may be closed by this pull request
@sroertgen sroertgen marked this pull request as ready for review December 16, 2022 12:00
@sroertgen sroertgen requested a review from acka47 December 16, 2022 12:00
@sroertgen sroertgen self-assigned this Dec 16, 2022
Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difficult case where some links between concept and schem are covered by hasTopConcept and others by topConceptof does not work. If it's not too problematic this should be working. See https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/w3id.org/kim/hcrt/scheme.en.html

@acka47
Copy link
Member

acka47 commented Dec 19, 2022

The difficult case where some links between concept and schem are covered by hasTopConcept and others by topConceptof does not work

I was wrong, everything works fine. +1

@acka47 acka47 self-requested a review December 19, 2022 12:06
@sroertgen sroertgen merged commit 70348d4 into master Dec 19, 2022
@sroertgen sroertgen deleted the 229-inverses-of-top-Concepts branch December 19, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inversion of topConceptOf und hasTopConcept
2 participants