Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoLinkToConceptScheme is to restrictive #1

Closed
acka47 opened this issue Dec 24, 2022 · 2 comments · Fixed by #2
Closed

NoLinkToConceptScheme is to restrictive #1

acka47 opened this issue Dec 24, 2022 · 2 comments · Fixed by #2
Assignees

Comments

@acka47
Copy link
Member

acka47 commented Dec 24, 2022

With skohub-io/skohub-vocabs#230 we made it possible to only add one of the inverse relations 'hasTopConcept or topConceptOf in SkoHub Vocabs. The Shape does not reflect this change yet and thus a build won't start in skohub-docker-vocabs:

https://github.com/skohub-io/shapes/blob/61d50c3046d157042e2581b8a48988dc64578044/skos.shacl.ttl#L156-L175

@sroertgen
Copy link
Contributor

I just noticed that the SKOS-Reference allows orphaned concept schemes: https://www.w3.org/TR/skos-reference/#L2497

So this rule is too restrictive anyway. I think about combining it with :OrphanConcepts and just give a warning.

https://github.com/skohub-io/shapes/blob/61d50c3046d157042e2581b8a48988dc64578044/skos.shacl.ttl#L178-L201

@acka47
Copy link
Member Author

acka47 commented Jan 25, 2023

I just noticed that the SKOS-Reference allows orphaned concept schemes: https://www.w3.org/TR/skos-reference/#L2497

You mean orphaned concepts. However, this must not mean that we must allow it in SKoHub Vocabs.

I think about combining it with :OrphanConcepts and just give a warning.

+1 This is a very good solution.

@sroertgen sroertgen linked a pull request Jan 25, 2023 that will close this issue
@acka47 acka47 assigned acka47 and sroertgen and unassigned sroertgen and acka47 Jan 26, 2023
nichtich added a commit to nichtich/shapes that referenced this issue Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants