Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update test script refs #474 #475

Merged
merged 5 commits into from
Mar 14, 2025
Merged

Conversation

abosio
Copy link
Contributor

@abosio abosio commented Mar 12, 2025

🎯 What needed to be done and why?

Ticket: #474

test-scaf.sh script needed to be updated to work with copier

🆕 What is changed by this PR?

📋 Code Review Cheatsheet

What the reviewer should check
Check Description
🚚 Diff size Is the PR small and focused, or should it be broken into smaller PRs?
🧪 Unit tests Are new features covered with appropriate unit tests?
🥼 Acceptance Criteria met Are the Acceptance Criteria listed in the issue met?
🧐 Code clarity Is the code easy to understand? Are variable and function names meaningful?
🧩 Code organization Are files, modules, and functions structured logically?
🪚 Conciseness Is the code free of unnecessary complexity or redundant code?
💬 Comments & documentation Are code comments explaining why and not how? Is the documentation up-to-date?
🧮 Code consistency Does the code follow existing patterns and conventions in the project?
☣️ Function length Are functions too long? Should they be broken into smaller, more focused functions?
☢️ Class design Are classes well-structured and not overly large or doing too much?
🐾 Logging and debugging statements Are print/debug statements removed or replaced with proper logging?

@abosio abosio requested a review from rehan892 March 12, 2025 18:10
@abosio abosio changed the title Abosio/474 update test script refactor: update test script refs #474 Mar 12, 2025
@abosio abosio merged commit 1315831 into dev Mar 14, 2025
2 of 3 checks passed
@abosio abosio deleted the abosio/474-update-test-script branch March 14, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants