Abosio/474 update test data #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2025 13:39
so that is doesn't copy test data files to the output directory
rehan892
approved these changes
Mar 14, 2025
abosio
added a commit
to sixfeetup/scaf
that referenced
this pull request
Mar 14, 2025
## 🎯 What needed to be done and why? Ticket: #474 test-scaf.sh script needed to be updated to work with copier ## 🆕 What is changed by this PR? - updated arguments to match copier - removed test data file (moved to it's template repo in sixfeetup/scaf-fullstack-template#1 ) - removed support for git branch since template repo is separate - will use whatever branch is checkout out for the template ## 📋 Code Review Cheatsheet <details> <summary>What the reviewer should check</summary> | Check | Description | | ------------- | ------------- | | 🚚 **Diff size** | Is the PR small and focused, or should it be broken into smaller PRs? | 🧪 **Unit tests** | Are new features covered with appropriate unit tests? | 🥼 **Acceptance Criteria met** | Are the Acceptance Criteria listed in the issue met? | 🧐 **Code clarity** | Is the code easy to understand? Are variable and function names meaningful? | 🧩 **Code organization** | Are files, modules, and functions structured logically? | 🪚 **Conciseness** | Is the code free of unnecessary complexity or redundant code? | 💬 **Comments & documentation** | Are code comments explaining *why* and not *how*? Is the documentation up-to-date? | 🧮 **Code consistency** | Does the code follow existing patterns and conventions in the project? | ☣️ **Function length** | Are functions too long? Should they be broken into smaller, more focused functions? | ☢️ **Class design** | Are classes well-structured and not overly large or doing too much? | 🐾 **Logging and debugging statements** | Are print/debug statements removed or replaced with proper logging? </details> --------- Co-authored-by: abosio <abosio@sixfeetup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 What needed to be done and why?
Ticket: sixfeetup/scaf#474
Now that the template is in a separate repo, the test data file(s) for it should live with it.
Probably should wait for the PR for the complimentary main repo changes for that ticket in case any changes are needed.
🆕 What is changed by this PR?
nextjs-django-github.yaml📋 Code Review Cheatsheet
What the reviewer should check