Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow unused values in associative foreach loops with option #167

Merged
merged 6 commits into from
Apr 19, 2020
Merged

Only allow unused values in associative foreach loops with option #167

merged 6 commits into from
Apr 19, 2020

Commits on Apr 19, 2020

  1. Fix syntax of ThisWithinNestedClosedScopeFixture 

    Weird that I never noticed that before.
    @sirbrillig
    sirbrillig committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    4522c95 View commit details
    Browse the repository at this point in the history

  2. Update tests to mark unused keys even with allowUnusedForeachVariables

    @sirbrillig
    sirbrillig committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    6945e77 View commit details
    Browse the repository at this point in the history

  3. Update description of allowUnusedForeachVariables to be accurate 

    This makes it clear that it only operates on the values of a `key =>
value` expression.
    @sirbrillig
    sirbrillig committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    0c576ce View commit details
    Browse the repository at this point in the history

  4. Adjust more tests which use default allowUnusedForeachVariables

    @sirbrillig
    sirbrillig committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    97d5aaa View commit details
    Browse the repository at this point in the history

  5. Only allow unused values in associative foreach loops with option

    @sirbrillig
    sirbrillig committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    b9a0d46 View commit details
    Browse the repository at this point in the history

  6. Fix unused foreach keys in sniff and helpers

    @sirbrillig
    sirbrillig committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    6d1cf25 View commit details
    Browse the repository at this point in the history