Only allow unused values in associative foreach loops with option #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weird that I never noticed that before.
This makes it clear that it only operates on the values of a `key => value` expression.
sirbrillig
added a commit
that referenced
this pull request
May 25, 2020
* Fix syntax of ThisWithinNestedClosedScopeFixture Weird that I never noticed that before. * Update tests to mark unused keys even with allowUnusedForeachVariables * Update description of allowUnusedForeachVariables to be accurate This makes it clear that it only operates on the values of a `key => value` expression. * Adjust more tests which use default allowUnusedForeachVariables * Only allow unused values in associative foreach loops with option * Fix unused foreach keys in sniff and helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the (by default enabled) option
allowUnusedForeachVariablesignored all variables created in aforeachstatement.The idea behind this option is that some foreach statements wish to use the key of an associative array and ignore the value, and doing so requires creating an unused value variable.
The idea and the implementation were not in accordance, however. This PR changes the meaning of the option from "do not mark any unused variable created in a foreach statement" to the more correct "do not mark any unused value variable created in a foreach statement on an associative array".
Fixes #166