Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolvesThis should override previous throws #1533

Merged
merged 1 commit into from
Aug 16, 2017
Merged

resolvesThis should override previous throws #1533

merged 1 commit into from
Aug 16, 2017

Conversation

noisecapella
Copy link
Contributor

Purpose (TL;DR) - mandatory

Fixed missing reset of exceptionCreator for resolvesThis which exists in other similar functions. Where exception is set to undefined exceptionCreator should also be set to `undefined.

How to verify - mandatory

In the branch, remove the change to default-behaviors.js and run the tests. One of the two new tests should fail, showing that the previous behavior is inconsistent regarding how throws affects resolveThis.

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@fatso83 fatso83 merged commit 4310343 into sinonjs:master Aug 16, 2017
@mroderick mroderick added the semver:patch changes will cause a new patch version label Aug 22, 2017
@mroderick
Copy link
Member

Thank you 👍

@mroderick
Copy link
Member

This was released with sinon@3.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatso83 fatso83 fatso83 approved these changes

Assignees
No one assigned
Labels
semver:patch changes will cause a new patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noisecapella @mroderick @fatso83