-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache references to Array.prototype.filter #1523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatso83
force-pushed
the
1521-stub-array-filter-fails
branch
from
August 10, 2017 10:31
0a9a3e8
to
052a2d0
Compare
I added no extra tests for the second commit. I simply couldn't find out how to add relevant tests, so I gave up after close to an hour of messing around with |
mantoni
approved these changes
Aug 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This has become part of |
fatso83
added a commit
that referenced
this pull request
Aug 10, 2017
2 tasks
This was referenced Aug 14, 2017
2 tasks
2 tasks
2 tasks
2 tasks
4 tasks
This was referenced Nov 9, 2017
2 tasks
2 tasks
This was referenced Aug 11, 2023
2 tasks
Merged
2 tasks
Merged
This was referenced Oct 31, 2023
This was referenced Nov 5, 2023
This was referenced Dec 22, 2023
This was referenced Jan 5, 2024
This was referenced Apr 25, 2024
2 tasks
This was referenced Sep 10, 2024
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes issue #1521 by caching references to the
filter
method so that it can be stubbed. Also adds a hint to the pull request template on things that should be in place.How to verify - mandatory
npm install
npm test