Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache references to Array.prototype.filter #1523

Merged
merged 3 commits into from
Aug 10, 2017

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Aug 10, 2017

Purpose

Fixes issue #1521 by caching references to the filter method so that it can be stubbed. Also adds a hint to the pull request template on things that should be in place.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

@fatso83 fatso83 force-pushed the 1521-stub-array-filter-fails branch from 0a9a3e8 to 052a2d0 Compare August 10, 2017 10:31
@fatso83
Copy link
Contributor Author

fatso83 commented Aug 10, 2017

I added no extra tests for the second commit. I simply couldn't find out how to add relevant tests, so I gave up after close to an hour of messing around with call.js and call-test.js, but at least all existing tests pass.

Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fatso83 fatso83 merged commit 81c23fb into sinonjs:master Aug 10, 2017
@mroderick mroderick added the semver:patch changes will cause a new patch version label Aug 10, 2017
@mroderick
Copy link
Member

This has become part of v3.2.0

fatso83 added a commit that referenced this pull request Aug 10, 2017
@fatso83 fatso83 deleted the 1521-stub-array-filter-fails branch August 14, 2017 07:45
@iilei iilei mentioned this pull request Aug 21, 2017
2 tasks
@killmenot killmenot mentioned this pull request Sep 3, 2017
2 tasks
@servel333 servel333 mentioned this pull request Sep 13, 2017
2 tasks
@vsa vsa mentioned this pull request Sep 18, 2017
2 tasks
@dazld dazld mentioned this pull request Oct 13, 2017
2 tasks
@DevLab2425 DevLab2425 mentioned this pull request Oct 14, 2017
2 tasks
@avaly avaly mentioned this pull request Oct 14, 2017
2 tasks
@gukoff gukoff mentioned this pull request Aug 11, 2023
2 tasks
This was referenced Sep 12, 2023
@fatso83 fatso83 mentioned this pull request Sep 26, 2023
@fatso83 fatso83 mentioned this pull request Oct 25, 2023
2 tasks
@remorses remorses mentioned this pull request Jan 4, 2024
2 tasks
@fatso83 fatso83 mentioned this pull request Oct 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch changes will cause a new patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants