removed check for sudo when adding network flags #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Do you want to bump the version (in version.py) and add a note to the CHANGELOG.md? If not I can do it later after work, and then the PR should be good to go! 👍 And glad to hear that Singularity lets this work now without sudo, it was always a hassle. |
arthurfeeney
force-pushed
the
sudo-net-fix
branch
from
dc59537 to
1ca543d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix so that singularity-compose will add the
--netflags when starting instances.This just removes the check for sudo when Instance.create attempts to add the network flags.