Skip to content

Commit

Permalink
removed check for sudo when adding network flags (#40)
Browse files Browse the repository at this point in the history
Co-authored-by: 6617ve <Arthur.Feeney@bp.com>
  • Loading branch information
arthurfeeney and 6617ve authored Feb 25, 2021
1 parent f8897e1 commit 39367e1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
The versions coincide with releases on pypi.

## [0.0.x](https://github.com/singularityhub/singularity-compose/tree/master) (0.0.x)
- removed check for sudo when adding network flags (0.0.21)
- singularity-compose down supporting timeout (0.0.20)
- command, ability to associate arguments to the instance's startscript (0.0.19)
- depends\_on, check circular dependencies at startup and shutdown in reverse order (0.0.18)
Expand Down
9 changes: 4 additions & 5 deletions scompose/project/instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -498,12 +498,11 @@ def create(self, ip_address=None, sudo=False, writable_tmpfs=False):
# Volumes
options += self._get_bind_commands()

if sudo:
# Ports
options += self._get_network_commands(ip_address)
# Ports
options += self._get_network_commands(ip_address)

# Hostname
options += ["--hostname", self.name]
# Hostname
options += ["--hostname", self.name]

# Writable Temporary Directory
if writable_tmpfs:
Expand Down
2 changes: 1 addition & 1 deletion scompose/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"""

__version__ = "0.0.20"
__version__ = "0.0.21"
AUTHOR = "Vanessa Sochat"
AUTHOR_EMAIL = "vsochat@stanford.edu"
NAME = "singularity-compose"
Expand Down

0 comments on commit 39367e1

Please sign in to comment.