Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some infinite scroll issues (#54) #55

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix some infinite scroll issues (#54) #55

merged 1 commit into from
Nov 22, 2022

Conversation

Moerlin1337
Copy link
Collaborator

  • fix: loadMore is only emitted once

  • fix: multiselect isn't cleared if options are removed in infinite mode

  • fix: don't emit 'loadMore' if options are currently loading

  • feat: performance rework

  • fix: if-condition

  • fix: remember selected options in infinite mode

  • chore: remove duplicate code

  • chore: remove unnecessary comments

Co-authored-by: Merlin Flach merlin.flach@singular-it.de

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
@OrbisK OrbisK merged commit 618dde0 into beta Nov 22, 2022
OrbisK added a commit that referenced this pull request Nov 22, 2022
OrbisK added a commit that referenced this pull request Nov 22, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

coronoro pushed a commit that referenced this pull request Nov 29, 2022
* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* docs: remove @beta in installation so it could be merged in main

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
OrbisK added a commit that referenced this pull request Dec 1, 2022
* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro added a commit that referenced this pull request Dec 7, 2022
* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)"

This reverts commit 618dde0.

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
coronoro added a commit that referenced this pull request Dec 7, 2022
* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro pushed a commit that referenced this pull request Dec 7, 2022
coronoro added a commit that referenced this pull request Dec 7, 2022
* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro pushed a commit that referenced this pull request Dec 7, 2022
coronoro added a commit that referenced this pull request Dec 7, 2022
* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: avoid reactive variables to trigger themselves (#61)

* fix: avoid reactive variables to trigger themselves

* docs: adapt readme to small prop changes

* fix: fix if condition, so optionValues can be arrays in single mode

* test: add array as value for some options

* chore: add selected Options as possible dependency for optionLabel again

* docs: adapt readme to changes

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* chore: merge beta into develop (#63)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* docs: remove @beta in installation so it could be merged in main

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Fix beta merge conflict (#64)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>

* Revert 55 develop (#65)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)"

This reverts commit 618dde0.

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro added a commit that referenced this pull request Dec 7, 2022
* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: avoid reactive variables to trigger themselves (#61)

* fix: avoid reactive variables to trigger themselves

* docs: adapt readme to small prop changes

* fix: fix if condition, so optionValues can be arrays in single mode

* test: add array as value for some options

* chore: add selected Options as possible dependency for optionLabel again

* docs: adapt readme to changes

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* chore: merge beta into develop (#63)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* docs: remove @beta in installation so it could be merged in main

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Fix beta merge conflict (#64)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>

* Revert 55 develop (#65)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)"

This reverts commit 618dde0.

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix: bugs caused by branch fix (#68)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: coronoro <streicher.tim@googlemail.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro added a commit that referenced this pull request Dec 12, 2022
* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: avoid reactive variables to trigger themselves (#61)

* fix: avoid reactive variables to trigger themselves

* docs: adapt readme to small prop changes

* fix: fix if condition, so optionValues can be arrays in single mode

* test: add array as value for some options

* chore: add selected Options as possible dependency for optionLabel again

* docs: adapt readme to changes

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* chore: merge beta into develop (#63)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* docs: remove @beta in installation so it could be merged in main

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Fix beta merge conflict (#64)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix some infinite scroll issues (#54) (#57)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix: bump version (#60)

* fix some infinite scroll issues (#54)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* feat: performance adjustments

* fix: bump version (#59)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>

* Revert 55 develop (#65)

* chore: remove develop from release config

* ci: fix missing `npx`

* polish: remove css stylesheet because it's never used

* style: rework styling a little to make external customization easier

* test: adapt tests to styling changes

* docs: adapt docs to styling changes

* feature: add types to build

* feat: add types to build

* fix: missing types

* fix: build Multiselect types correctly (#39)

* fix some infinite scroll issues (#54) (#55)

* fix: loadMore is only emitted once

* fix: multiselect isn't cleared if options are removed in infinite mode

* fix: don't emit 'loadMore' if options are currently loading

* feat: performance rework

* fix: if-condition

* fix: remember selected options in infinite mode

* chore: remove duplicate code

* chore: remove unnecessary comments

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* Revert "fix some infinite scroll issues (#54) (#55)"

This reverts commit 618dde0.

Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>

* Revert "fix some infinite scroll issues (#54) (#55)" (#56)

This reverts commit 618dde0.

* fix: bugs caused by branch fix (#68)

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

* fix a few bugs (#70)

* fix: blur search input if the dropdown closes (closeOnSelect)

* fix: change default modelValue in single select to undefined (means no selection) instead of null

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>

Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
Co-authored-by: Robin Kehl <robin.kehl@singular-it.de>
Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com>
Co-authored-by: coronoro <streicher.tim@googlemail.com>
Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants