fix some infinite scroll issues #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrbisK
reviewed
Nov 7, 2022
src/Multiselect.vue
Outdated
Comment on lines
456
to
465
| if (!props.infinite) { | ||
| if (newOptions && newOptions.length > 0) { | ||
| for (const option of oldOptions) { | ||
| if (!_.some(newOptions, option as never) && options.isSelected(option, options.selectedOptions.value)) | ||
| options.deselect(option) | ||
| } | ||
| } | ||
| else { | ||
| multiselect.clear() | ||
| } |
There was a problem hiding this comment.
@coronoro, irgendwie bin ich hier nicht so fan vom loop im watcher und den if statements. Siehst du Verbesserungspotential?
There was a problem hiding this comment.
@Moerlin1337, wieso ist der type von option never?
There was a problem hiding this comment.
btw gibt es auch von vueUse ein infinite scrolling https://vueuse.org/core/useinfinitescroll/#useinfinitescroll
coronoro
reviewed
Nov 22, 2022
src/utils/useOptions.ts
Outdated
| } | ||
| else { | ||
| return false | ||
| correctValues = null |
There was a problem hiding this comment.
correctValues wird mit undefined initialisiert. Die Zuweisung wird nicht gebraucht.
|
@OrbisK Kannst du bitte nochmal über die Änderungen schauen ob du noch was findest? |
coronoro
approved these changes
Nov 22, 2022
OrbisK
approved these changes
Nov 22, 2022
OrbisK
pushed a commit
that referenced
this pull request
Nov 22, 2022
* fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
OrbisK
added a commit
that referenced
this pull request
Nov 22, 2022
OrbisK
added a commit
that referenced
this pull request
Nov 22, 2022
* fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
OrbisK
added a commit
that referenced
this pull request
Nov 22, 2022
* fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
coronoro
pushed a commit
that referenced
this pull request
Nov 29, 2022
* chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * docs: remove @beta in installation so it could be merged in main Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
OrbisK
added a commit
that referenced
this pull request
Dec 1, 2022
* chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro
added a commit
that referenced
this pull request
Dec 7, 2022
* chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" This reverts commit 618dde0. Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com>
coronoro
pushed a commit
that referenced
this pull request
Dec 7, 2022
* fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de>
coronoro
added a commit
that referenced
this pull request
Dec 7, 2022
* chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro
added a commit
that referenced
this pull request
Dec 7, 2022
* chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro
added a commit
that referenced
this pull request
Dec 7, 2022
* fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: avoid reactive variables to trigger themselves (#61) * fix: avoid reactive variables to trigger themselves * docs: adapt readme to small prop changes * fix: fix if condition, so optionValues can be arrays in single mode * test: add array as value for some options * chore: add selected Options as possible dependency for optionLabel again * docs: adapt readme to changes Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * chore: merge beta into develop (#63) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * docs: remove @beta in installation so it could be merged in main Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Fix beta merge conflict (#64) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de> * Revert 55 develop (#65) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" This reverts commit 618dde0. Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro
added a commit
that referenced
this pull request
Dec 7, 2022
* fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: avoid reactive variables to trigger themselves (#61) * fix: avoid reactive variables to trigger themselves * docs: adapt readme to small prop changes * fix: fix if condition, so optionValues can be arrays in single mode * test: add array as value for some options * chore: add selected Options as possible dependency for optionLabel again * docs: adapt readme to changes Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * chore: merge beta into develop (#63) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * docs: remove @beta in installation so it could be merged in main Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Fix beta merge conflict (#64) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de> * Revert 55 develop (#65) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" This reverts commit 618dde0. Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix: bugs caused by branch fix (#68) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: coronoro <streicher.tim@googlemail.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
coronoro
added a commit
that referenced
this pull request
Dec 12, 2022
* fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: avoid reactive variables to trigger themselves (#61) * fix: avoid reactive variables to trigger themselves * docs: adapt readme to small prop changes * fix: fix if condition, so optionValues can be arrays in single mode * test: add array as value for some options * chore: add selected Options as possible dependency for optionLabel again * docs: adapt readme to changes Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * chore: merge beta into develop (#63) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * docs: remove @beta in installation so it could be merged in main Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Fix beta merge conflict (#64) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix some infinite scroll issues (#54) (#57) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix: bump version (#60) * fix some infinite scroll issues (#54) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * feat: performance adjustments * fix: bump version (#59) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de> * Revert 55 develop (#65) * chore: remove develop from release config * ci: fix missing `npx` * polish: remove css stylesheet because it's never used * style: rework styling a little to make external customization easier * test: adapt tests to styling changes * docs: adapt docs to styling changes * feature: add types to build * feat: add types to build * fix: missing types * fix: build Multiselect types correctly (#39) * fix some infinite scroll issues (#54) (#55) * fix: loadMore is only emitted once * fix: multiselect isn't cleared if options are removed in infinite mode * fix: don't emit 'loadMore' if options are currently loading * feat: performance rework * fix: if-condition * fix: remember selected options in infinite mode * chore: remove duplicate code * chore: remove unnecessary comments Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * Revert "fix some infinite scroll issues (#54) (#55)" This reverts commit 618dde0. Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Moerlin1337 <105291378+Moerlin1337@users.noreply.github.com> * Revert "fix some infinite scroll issues (#54) (#55)" (#56) This reverts commit 618dde0. * fix: bugs caused by branch fix (#68) Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> * fix a few bugs (#70) * fix: blur search input if the dropdown closes (closeOnSelect) * fix: change default modelValue in single select to undefined (means no selection) instead of null Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Merlin Flach <merlin.flach@singular-it.de> Co-authored-by: Robin Kehl <robin.kehl@singular-it.de> Co-authored-by: OrbisK <37191683+OrbisK@users.noreply.github.com> Co-authored-by: coronoro <streicher.tim@googlemail.com> Co-authored-by: Tim Streicher <tim.streicher@singular-it.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.