-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++/python] Fixes for dense arrays and core 2.27/dev
[WIP]
#3244
base: main
Are you sure you want to change the base?
Conversation
dev
[WIP]
Investigation so far shows that Python dense-array write calls C++ cc @mojaveazure and your observation the other day that the dense-array writer doesn't handle coords. Furthermore, as presently coded, it can only write the full core domain of the array. And now that with the new-shape feature flag enabled, the core domain (soma maxdomain) is huge and the core current domain (soma domain) is small. Here is a repro that fails even with the new-shape feature flag disabled, proving that this bug is older than the new-shape mod:
Also fails with
Same error message. |
0c00c0f
to
a1e5b1c
Compare
The typeguard-related failures are new and weird. I created #3245 to check. |
CI run from commit 1 failed: https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11542968229/job/32126790602?pr=3245 |
ad27cf8
to
66e34ff
Compare
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Changes:
Some findings from TileDB-Inc/centralized-tiledb-nightlies#25. There is more to do though.
Notes for Reviewer:
This PR is a work in progress. It is not ready for review.
Python read-OOM repro
R write-fail repro