Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python/ci] Investigate recent CI failure #3246

Closed
johnkerl opened this issue Oct 28, 2024 · 2 comments
Closed

[python/ci] Investigate recent CI failure #3246

johnkerl opened this issue Oct 28, 2024 · 2 comments
Assignees
@ryan-williams

Comments

@johnkerl
Copy link
Member

johnkerl commented Oct 28, 2024 •
edited
Loading

Recent CI jobs are failing with typeguard-related errors. Examples:

As an experiment I took a recent merge to main and simply re-ran it with zero code mods:

The only diffs I could find by log-diffing were pyarrow 17 vs 18, which I've ruled out via #3245; also typeguard 4.4.0 recently came out and I don't believe that's the problem either but I'll verify.

[sc-58398]
@johnkerl johnkerl mentioned this issue Oct 28, 2024
Open
@ryan-williams ryan-williams mentioned this issue Oct 28, 2024
Merged
@ryan-williams
Copy link
Member

main is green again as of #3247.

Pinning to a specific typeguard SHA should be reasonably stable, though not ideal "long-term." I'll look into the actual issue a bit more, it may require a small change in Typeguard.

#3216 may be the best place for follow-up, and close this since CI is OK again?

ryan-williams added a commit to ryan-williams/SOMA that referenced this issue Oct 28, 2024
@ryan-williams
rm py3.9 __subclasscheck__ workaround
cf45e7f 
It seems to be causing issues in TileDB-SOMA CI
(single-cell-data/TileDB-SOMA#3246),
and it doesn't seem to be necessary for any tests.
@johnkerl
Copy link
Member Author

Sounds great, thanks @ryan-williams !

@johnkerl johnkerl mentioned this issue Oct 28, 2024
Open
@ryan-williams ryan-williams mentioned this issue Oct 28, 2024
Merged
ryan-williams added a commit to single-cell-data/SOMA that referenced this issue Oct 28, 2024
@ryan-williams
rm py3.9 __subclasscheck__ workaround
8e91526 
It seems to be causing issues in TileDB-SOMA CI
(single-cell-data/TileDB-SOMA#3246),
and it doesn't seem to be necessary for any tests.
@ryan-williams ryan-williams mentioned this issue Oct 28, 2024
Draft
ryan-williams added a commit to single-cell-data/SOMA that referenced this issue Oct 28, 2024
@ryan-williams
rm py3.9 __subclasscheck__ workaround (#240)
088a243 
It seems to be causing issues in TileDB-SOMA CI
(single-cell-data/TileDB-SOMA#3246),
and it doesn't seem to be necessary for any tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan-williams ryan-williams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryan-williams @johnkerl