Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.5.1: Request all types of subscriptions #113

Merged
merged 4 commits into from
Dec 31, 2021
Merged

v1.5.1: Request all types of subscriptions #113

merged 4 commits into from
Dec 31, 2021

Conversation

dmosorast
Copy link
Contributor

@dmosorast dmosorast commented Dec 31, 2021 •
edited
Loading

Description of change

The tap wasn't requesting all types of subscriptions, so canceled subscriptions didn't come through. This PR changes that and adds a pattern for an individual stream to customize its request.

See stripe docs on the request param: https://stripe.com/docs/api/subscriptions/list

Manual QA steps

  • Manually confirmed that a canceled subscription was returned after making this change, and wasn't returned before the change.

Risks

  • Row volume increase might be significant depending on the data set, but a more complete data set is worth it IMO

Rollback steps

  • revert this branch, release new patch version

@dmosorast dmosorast mentioned this pull request Dec 31, 2021
Closed
zachharris1
zachharris1 approved these changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@zachharris1 zachharris1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmosorast dmosorast merged commit a04bfa1 into master Dec 31, 2021
@dmosorast dmosorast deleted the request-all-subscriptions branch December 31, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisPersonal KrisPersonal KrisPersonal approved these changes

@zachharris1 zachharris1 zachharris1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmosorast @KrisPersonal @zachharris1