Sync all stripe subscriptions not only the active ones #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The default setting of the API is to return only non-cancelled subscriptions - as stated in the docs:
This leads to the problem that we currently technically only sync not cancelled subscriptions and exclude the cancelled ones. However, it seems that some - but not all - cancelled ones are included in the request (I could not figure out why).
To tackle the problem I did the following changes:
request_args
parameter to theSTREAM_SDK_OBJECTS
which can be used to specify additional request parameters for the api callsubscriptions
to fetch subscriptions with anystatus
Manual QA steps
SELECT COUNT(*)
on the resultsSELECT COUNT(*)
on the results -> you should have all subscriptions nowRisks
Rollback steps