Tdl 15623 crest master #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit for best practice update * updated setup.py and start_date test * Updated test cases * Updated start_date test case * Updated start_date test case * Updated comment * Revert back test case changes * Added new line
* Initial commit for pagination failer * Fixed pagination test cases * Added comments * Added detail comment into the code * Removed unnecessary comment * Removed unnecessary assertion * Removed extra comment
* added unsupported feature and unittests * added code comments * fixed indent * fixed indentation * resolved a bug of writing md when 2 consecutive empty headers * updated the logic for consecutive empty headers * rsolved comments * added test case for consecutive empty headers * added comments * resolved circleci errors * resolved comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasystems.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>
* added logger message and unittests * added code comments * changed the logger message and logic * resolved comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasystems.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>
* TDL-16054 added code comments * rsolved comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasystems.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>
* TDL-16280 added request timeout * TDL-16280: Added factor 3 to add more wait time between 2 calls * TDL-16280: Updated Connection error as it wasn't defined. * added backoff for access token * updated readme * updated request timeout and added jitter * added comment for jitter * added code coverage * added testcase for connection error * addd request timeout in config example * updated the json example * removed the client initialization outside with Co-authored-by: dbshah1212 <dhruvin.shah@crestdatasys.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>
KrisPersonal
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps