Tdl 16280 implement request timeout #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
reviewed
Nov 16, 2021
dbshah1212
reviewed
Nov 16, 2021
dbshah1212
approved these changes
Nov 25, 2021
savan-chovatiya
approved these changes
Nov 26, 2021
karanpanchal-crest
approved these changes
Dec 8, 2021
kspeer825
approved these changes
Dec 8, 2021
Comment on lines
18
to
20
| with self.assertRaises(Timeout): | ||
| client = GoogleClient("dummy_client_id", "dummy_client_secret", "dummy_refresh_token", 300) | ||
| client.request("GET") |
There was a problem hiding this comment.
I think the client instantiation should be moved outside of this with block. It is unclear what is being tested otherwise.
There was a problem hiding this comment.
Yes, removed it from the with
KrisPersonal
approved these changes
Dec 8, 2021
…-16280-implement-request-timeout
Merged
KrisPersonal
pushed a commit
that referenced
this pull request
Dec 13, 2021
* type of emailaddress corrected (#53) * Tdl 16079 check best practices (#51) * Initial commit for best practice update * updated setup.py and start_date test * Updated test cases * Updated start_date test case * Updated start_date test case * Updated comment * Revert back test case changes * Added new line * Tdl 14376 pagination failure (#50) * Initial commit for pagination failer * Fixed pagination test cases * Added comments * Added detail comment into the code * Removed unnecessary comment * Removed unnecessary assertion * Removed extra comment * added comment for bug (#49) * TDL-14475 added unsupported feature and unittests (#47) * added unsupported feature and unittests * added code comments * fixed indent * fixed indentation * resolved a bug of writing md when 2 consecutive empty headers * updated the logic for consecutive empty headers * rsolved comments * added test case for consecutive empty headers * added comments * resolved circleci errors * resolved comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasystems.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * TDL-14397-Add skipped log when first row is empty (#46) * added logger message and unittests * added code comments * changed the logger message and logic * resolved comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasystems.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * TDL-16054 added code comments (#52) * TDL-16054 added code comments * rsolved comments Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasystems.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * Tdl 16280 implement request timeout (#54) * TDL-16280 added request timeout * TDL-16280: Added factor 3 to add more wait time between 2 calls * TDL-16280: Updated Connection error as it wasn't defined. * added backoff for access token * updated readme * updated request timeout and added jitter * added comment for jitter * added code coverage * added testcase for connection error * addd request timeout in config example * updated the json example * removed the client initialization outside with Co-authored-by: dbshah1212 <dhruvin.shah@crestdatasys.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com> Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasystems.com> Co-authored-by: dbshah1212 <dhruvin.shah@crestdatasys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Implement request timeout with parameter provided in config
Manual QA steps
Risks
Rollback steps