Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tap-facebook does not currently support DMA breakdown of ads_insights #45

Closed
dsprayberry opened this issue Jul 27, 2018 · 0 comments · Fixed by #62
Closed

tap-facebook does not currently support DMA breakdown of ads_insights #45

dsprayberry opened this issue Jul 27, 2018 · 0 comments · Fixed by #62

Comments

@dsprayberry
Copy link
Contributor

This is a standard breakdown offered for the Insights endpoint that breaks reports down by Designated Market Area.
aiguofer added a commit to aiguofer/tap-facebook that referenced this issue Jul 3, 2019
@aiguofer
Add Designated Market Area (DMA) breakdown for Insights report
40948c8 
Fixes singer-io#45
@aiguofer aiguofer mentioned this issue Jul 3, 2019
Merged
bradcosine pushed a commit to LullCode/tap-facebook that referenced this issue Jan 16, 2020
@mcampbell-lull @aiguofer
@cosimon @luandy64 @KAllan357 @nick-mccoy @bradcosine
Bring Lull Tap Facebook Fork up to Date (#1)
713b2a5 
* Add Designated Market Area (DMA) breakdown for Insights report

Fixes singer-io#45

* Revert "Add Designated Market Area (DMA) breakdown for Insights report"

* Add ads_insights_dma.json

* Add ads_insights_dma.json

* Revert "Merge pull request singer-io#63 from singer-io/revert-62-facebook_dma"

This reverts commit 9954380, reversing
changes made to 4db3088.

* version 1.6.0

* Switched from annotated schema to metadata (singer-io#67)

* Switched from annotated schema to metadata

* empty commit for testing

* Fix unit tests and run integration tests in circle

* Bump to v1.7.0, Changelog update

* Bump `facebook_business` version (singer-io#68)

* Update facebook_business dependency

* Remove deprecated video_p95_watched_actions field from schemas

See https://developers.facebook.com/ads/blog/post/2018/07/31/mapi-video-metrics/

* Bump to v1.7.1 with changelog update

* Change remote_read to api_get (singer-io#69)

* update changelog

* Add PR template

* SUP-956: Limit API request to avoid 500 (singer-io#71)

* Update RESULT_RETURN_LIMIT if passed in from config

* WIP: Date windowing on adcreative stream

* Undo changes to state

* Simplify result_return_limit override

* Add a comment

* Include end date in the sync

* Bump to v1.8.0, update changelog (singer-io#72)

* modify AdCreative stream to sync via batch API (singer-io#73)

* bump to 1.8.1 (singer-io#74)

* SRCE-1867: Add tap-tester tests (singer-io#75)

* Prepare for tap-tester tets to live in /tests

* Add tap-tester tests

* add `video_play_curve_actions` to ads_insights schemas (singer-io#80)

* add `video_play_curve_actions` to ads_insights schemas

* add ads_histogram_stats.json shared schema

* bump version to 1.8.2 (singer-io#81)

* update pip (singer-io#82)

Co-authored-by: Diego Fernández Giraldo <aiguo.fernandez@gmail.com>
Co-authored-by: Christopher Merrick <cmerrick@talend.com>
Co-authored-by: cosimon <cosimon@users.noreply.github.com>
Co-authored-by: Andy Lu <luandy64@gmail.com>
Co-authored-by: Kyle Allan <KAllan357@gmail.com>
Co-authored-by: Nick McCoy <33731945+nick-mccoy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Designated Market Area (DMA) breakdown for Insights report aiguofer/tap-facebook
1 participant
@dsprayberry