Add Designated Market Area (DMA) breakdown for Insights report

Fixes singer-io#45
aiguofer · Jul 3, 2019 · 40948c8 · 40948c8
1 parent 95fd2a3
commit 40948c8
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/tap_facebook/__init__.py b/tap_facebook/__init__.py
@@ -49,7 +49,9 @@
     'ads_insights_age_and_gender',
     'ads_insights_country',
     'ads_insights_platform_and_device',
-    'ads_insights_region']
+    'ads_insights_region',
+    'ads_insights_dma',
+]
 
 REQUIRED_CONFIG_KEYS = ['start_date', 'account_id', 'access_token']
 UPDATED_TIME_KEY = 'updated_time'
@@ -63,7 +65,8 @@
     'ads_insights_age_and_gender': START_DATE_KEY,
     'ads_insights_country': START_DATE_KEY,
     'ads_insights_platform_and_device': START_DATE_KEY,
-    'ads_insights_region': START_DATE_KEY
+    'ads_insights_region': START_DATE_KEY,
+    'ads_insights_dma': START_DATE_KEY,
 }
 
 LOGGER = singer.get_logger()
@@ -405,7 +408,7 @@ class AdsInsights(Stream):
     bookmark_key = START_DATE_KEY
 
     invalid_insights_fields = ['impression_device', 'publisher_platform', 'platform_position',
-                               'age', 'gender', 'country', 'placement', 'region']
+                               'age', 'gender', 'country', 'placement', 'region', 'dma']
 
     # pylint: disable=no-member,unsubscriptable-object,attribute-defined-outside-init
     def __attrs_post_init__(self):
@@ -518,7 +521,9 @@ def __iter__(self):
                                          "primary-keys": ['publisher_platform',
                                                           'platform_position', 'impression_device']},
     'ads_insights_region': {'breakdowns': ['region'],
-                            'primary-keys': ['region']}
+                            'primary-keys': ['region']},
+    'ads_insights_dma': {"breakdowns": ['dma'],
+                         "primary-keys": ['dma']},
 }